Refactor everserver 2 #9777
Merged
Refactor everserver 2 #9777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
2 times, most recently
from
249e947 to
d0b2ca4
Compare
CodSpeed Performance ReportMerging #9777 will not alter performanceComparing Summary
|
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
from
1e6e488 to
071bbbc
Compare
frode-aarstad
added
the
release-notes:maintenance
oyvindeide
reviewed
Jan 20, 2025
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
3 times, most recently
from
3d5df0c to
8334307
Compare
yngve-sk
reviewed
Jan 24, 2025
| run_model.run_experiment(evaluator_server_config) | ||
| self._exit_code = run_model.exit_code | ||
| except Exception: | ||
| self._exit_code = EverestExitCode.EXCEPTION |
There was a problem hiding this comment.
Should we store/propagate the error exception message too so it can be passed back to the client?
yngve-sk
reviewed
Jan 24, 2025
yngve-sk
reviewed
Jan 24, 2025
|
looking good to me, only some questions/comments about error propagation for the endpoints |
frode-aarstad
force-pushed
the
refactor-everserver-2
branch
from
5c92cb5 to
dbee95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9290
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable